Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Update README #32

Merged
merged 2 commits into from
Dec 12, 2017
Merged

Update README #32

merged 2 commits into from
Dec 12, 2017

Conversation

jwasinger
Copy link
Contributor

WIP

  • Indicate callbacks which are required
  • Make argument naming more consistent
  • Spelling correction

@coveralls
Copy link

Coverage Status

Coverage remained the same at 64.078% when pulling 4af2bfe on update-readme into 0fad9e7 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 64.078% when pulling 13cb5a4 on update-readme into 0fad9e7 on master.

@axic
Copy link
Member

axic commented Dec 10, 2017

Can we merge this?

@jwasinger
Copy link
Contributor Author

Yes. Please do

@axic
Copy link
Member

axic commented Dec 12, 2017

@jwasinger can you please rebase and merge?

@jwasinger
Update README (WIP)
e5f05e8 
* Indicate callbacks which are required
* Make argument naming more consistent
* Spelling correction
@jwasinger
add better description of getBlockDetails callback parameter. Add ref…
9bf2d93 
…erence to ethereumjs-block.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 64.078% when pulling 9bf2d93 on update-readme into 76c0c02 on master.

@axic axic merged commit 888e3ff into master Dec 12, 2017
@axic axic deleted the update-readme branch December 12, 2017 03:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@axic axic axic approved these changes

@holgerd77 holgerd77 Awaiting requested review from holgerd77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jwasinger @coveralls @axic