Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: Remove retired dev networks #1294

Closed
holgerd77 opened this issue Jun 10, 2021 · 3 comments
Closed

Common: Remove retired dev networks #1294

holgerd77 opened this issue Jun 10, 2021 · 3 comments

Comments

@holgerd77
Copy link
Member

As some housekeeping I guess we can remove the retired dev networks again from Common, these are:

  • Yolov3
  • Aleut
  • Baikal

References to remove are:

  • The chain files (aleut.json)
  • References in chains/index.ts
  • Likely some test cases
  • The listing in the respective README section

(or do we want to keep for some kind of historical reasons or something?)

@emersonmacro
Copy link
Contributor

@holgerd77 I put up a PR (#1296) - it was pretty straightforward cleanup. I didn't see any affected tests in the common package, but the automated checks on the PR caught that there is a test in the tx package that uses the aleut network: https://github.com/ethereumjs/ethereumjs-monorepo/pull/1296/checks?check_run_id=2808390978#step:7:23

Looks like it's a set of tests for EIP1559 transactions - https://github.com/ethereumjs/ethereumjs-monorepo/blob/master/packages/tx/test/eip1559.spec.ts#L9

I'm not fully up to speed on EIP1559... Can I update that test file to use a different chain? Should I add aleut back to the common package?

@emersonmacro
Copy link
Contributor

I updated the PR, converted the eip1559 test in tx to use rinkeby instead of aleut

@holgerd77
Copy link
Member Author

Closed by #1296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants