We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As some housekeeping I guess we can remove the retired dev networks again from Common, these are:
Common
References to remove are:
aleut.json
chains/index.ts
(or do we want to keep for some kind of historical reasons or something?)
The text was updated successfully, but these errors were encountered:
@holgerd77 I put up a PR (#1296) - it was pretty straightforward cleanup. I didn't see any affected tests in the common package, but the automated checks on the PR caught that there is a test in the tx package that uses the aleut network: https://github.com/ethereumjs/ethereumjs-monorepo/pull/1296/checks?check_run_id=2808390978#step:7:23
common
tx
aleut
Looks like it's a set of tests for EIP1559 transactions - https://github.com/ethereumjs/ethereumjs-monorepo/blob/master/packages/tx/test/eip1559.spec.ts#L9
I'm not fully up to speed on EIP1559... Can I update that test file to use a different chain? Should I add aleut back to the common package?
Sorry, something went wrong.
I updated the PR, converted the eip1559 test in tx to use rinkeby instead of aleut
eip1559
rinkeby
Closed by #1296
emersonmacro
No branches or pull requests
As some housekeeping I guess we can remove the retired dev networks again from
Common
, these are:References to remove are:
aleut.json
)chains/index.ts
(or do we want to keep for some kind of historical reasons or something?)
The text was updated successfully, but these errors were encountered: