Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common/Blockchain: add browser tests #1338

Closed
holgerd77 opened this issue Jul 8, 2021 · 1 comment · Fixed by #1380
Closed

Common/Blockchain: add browser tests #1338

holgerd77 opened this issue Jul 8, 2021 · 1 comment · Fixed by #1380
Assignees
@emersonmacro
Labels
package: blockchain package: common prio: P3 important type: CI type: enhancement type: tests

Comments

@holgerd77
Copy link
Member

There are actually no Common browser tests. Karma is not integrated and there are no respective npm script commands like npm run test:browser and the like.

This should be added following the structure of the other libraries like e.g. the browser test integration in the block library (just as some example which makes some consistent impression on first look).
@holgerd77 holgerd77 changed the title Common: add browser tests Common/Blockchain: add browser tests Jul 8, 2021
@holgerd77
Copy link
Member Author

Actually this is also true for the Blockchain package.

@emersonmacro emersonmacro self-assigned this Jul 28, 2021
@emersonmacro emersonmacro mentioned this issue Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emersonmacro emersonmacro

Labels
package: blockchain package: common prio: P3 important type: CI type: enhancement type: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Common, Blockchain: add browser tests ethereumjs/ethereumjs-monorepo
2 participants
@holgerd77 @emersonmacro