-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common, Blockchain: add browser tests #1380
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
@ryanio I took a stab at #1338. Build processes are definitely not my specialty - I got a setup working in Also, I got a linting error on code I didn't touch - it was complaining that |
@emersonmacro thanks for getting started on this! i am going to switch from seems to all be passing for me locally, let's see how ci does. |
…o output `test-build`)
haven't seen that before, and didn't get any errors locally when i removed the newly added ignores for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@ryanio thanks! |
Closes #1338