Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong util package in dependencies #2373

Closed
thevaizman opened this issue Oct 19, 2022 · 10 comments
Closed

Wrong util package in dependencies #2373

thevaizman opened this issue Oct 19, 2022 · 10 comments

Comments

@thevaizman
Copy link

The package.json file of the blockchain package still has the util version as 8.0.0 which doesn't have the Lock class in it instead of the new util version - 8.0.1.
I can see that you merged a fix to master - here.

Any idea when will this fix be pushed to yarnpkg? I can still see the wrong package.json file there.

cc: @holgerd77

@holgerd77
Copy link
Member

Hi there, we only had this out in this constallation for 30 minutes or so, we just missed the Util release initially. Now I have also released Util v8.0.1, see #2371. So if you now install (e.g. Blockchain) the Util package should be picked up due to the ^ version range.

@thevaizman
Copy link
Author

@holgerd77 I'd expect that too. But for some reason, when I perform a fresh yarn install, under /node_modules/@ethereumjs/blockchain/node_modules/@ethereumjs/util/package.json I can see that the version installed as a dependency for blockchain is still 8.0.0.

Wondering if this is some weird local bug on my end...

@thevaizman
Copy link
Author

btw, managed to fix that issue only by stating the following in my package.json:

  "resolutions": {
    "@ethereumjs/util": "8.0.1"
  }

@holgerd77
Copy link
Member

btw, managed to fix that issue only by stating the following in my package.json:

  "resolutions": {
    "@ethereumjs/util": "8.0.1"
  }

Hmm, we also have problems with this async event emitter fix solution we choose #2303 (comment), not yet clear how to proceed there.

Eventually we just need to do another round of adopting releases anyhow.

Hmm. Bit annoying.

@thevaizman
Copy link
Author

Yeah, I can relate to these issues you mentioned.
I am trying to use the exact same mechanism to cause the interpreter to hang until my callback function is invoked, but it doesn't seem to be available in the new library :/

Thanks for updating.

@acolytec3
Copy link
Contributor

@thevaizman Is this resolved with the latest release? Just want to confirm if we have more yet to do or can close this.

@thevaizman
Copy link
Author

thevaizman commented Oct 24, 2022

So it is not yet resolved "automatically" as I still have to add this to my package.json:

  "resolutions": {
    "@ethereumjs/util": "8.0.2"
  }

@holgerd77
Copy link
Member

I've now also released a new Blockchain version along an EVM fix release in #2380, so this should now be mitigated, will close.

@holgerd77
Copy link
Member

( @thevaizman eventually it would still be re-assuring if you could give a short confirmation if easily possible )

@thevaizman
Copy link
Author

hey @holgerd77, I can confirm this new release fixed the issue.
I can now safely remove the added resolutions part from my package.json and the app will build and run.

thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants