Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cacheTest.js still references .trie instead of the new ._trie #426

Closed
davidmurdoch opened this issue Jan 23, 2019 · 2 comments
Closed

cacheTest.js still references .trie instead of the new ._trie #426

davidmurdoch opened this issue Jan 23, 2019 · 2 comments
Labels
package: vm

Comments

@davidmurdoch
Copy link
Contributor

Are these cache tests still valid with the new refactoring? If they are I can go ahead and make a quick PR to update them from ._trie to .trie. If not, it'd be great to remove them all together so npm test will work. Let me know if you want that PR!
@s1na
Copy link
Contributor

s1na commented Jan 28, 2019

Some of the tests, including cacheTest.js, genesishashes.js and hooked.js haven't been updated (apart from small fixes) for a while, and they're not even tested on CI. It might make sense to go through them and see if they are still relevant, and fix them if so.

It was planned to write a few more tests after the refactoring, I can then also have a look at these three test files. Thanks for the reminder!

@s1na s1na mentioned this issue Jan 28, 2019
Merged
@holgerd77
Copy link
Member

Fixed by #427.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@evertonfraga @davidmurdoch @holgerd77 @s1na