Add unit tests for cache, convert it to es6 class #427
Conversation
Signed-off-by: Sina Mahmoodi <itz.s1na@gmail.com>
Signed-off-by: Sina Mahmoodi <itz.s1na@gmail.com>
Signed-off-by: Sina Mahmoodi <itz.s1na@gmail.com>
Signed-off-by: Sina Mahmoodi <itz.s1na@gmail.com>
Signed-off-by: Sina Mahmoodi <itz.s1na@gmail.com>
Signed-off-by: Sina Mahmoodi <itz.s1na@gmail.com>
| constructor (trie) { | ||
| this._cache = Tree() | ||
| this._checkpoints = [] | ||
| this._trie = trie | ||
| } |
| let account = this.lookup(key) | ||
| if (!account) { | ||
| account = new Account() | ||
| } | ||
| return account | ||
| } |
There was a problem hiding this comment.
put and get equivalent, ok, like this explicit addition of the default false value for fromTrie.
| const account = new Account(it.value.val) | ||
| return account | ||
| } | ||
| } |
| if (err) return cb(err) | ||
| self._update(key, account, false, false) | ||
| var account = new Account(raw) | ||
| cb(null, account) | ||
| }) | ||
| } |
| cb(null, account) | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
With addition of nextTick, ok.
| it.value.val = (new Account()).serialize() | ||
| self._trie.del(Buffer.from(it.key, 'hex'), function () { | ||
| }, cb) | ||
| } |
| async.nextTick(done) | ||
| } | ||
| }, cb) | ||
| } |
There was a problem hiding this comment.
Also a `nextTick' addition, ok.
| modified: modified, | ||
| deleted: deleted | ||
| }) | ||
| } |
There was a problem hiding this comment.
Everything ok, looked for change equivalency and completeness.
|
|
||
| st.end() | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Really nice test addition, great!
| @@ -242,7 +242,6 @@ function runTests (name, runnerArgs, cb) { | |||
|
|
|||
| function runAll () { | |||
| require('./tester.js') | |||
| require('./cacheTest.js') | |||
There was a problem hiding this comment.
Yes, think it's safe to remove.
|
Just for info: have set For |
tests/cacheTest.js, as it hasn't been in use for some time (and it doesn't seem related to cache?) (see also cacheTest.js still references.trieinstead of the new._trie#426)