Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group precompiles based on HF #585

Closed
s1na opened this issue Aug 30, 2019 · 1 comment · Fixed by #783
Closed

Group precompiles based on HF #585

s1na opened this issue Aug 30, 2019 · 1 comment · Fixed by #783
Assignees
@jochem-brouwer
Labels
effort: E1 hours package: vm prio: P2 very important

Comments

@s1na
Copy link
Contributor

s1na commented Aug 30, 2019

While working on #584 I noticed that the precompiles are not dependent on the HF at all. This means a bytecode running in Byzantium could call the blake2f precompile which is being introduced in Istanbul!

The simplest fix would be to check in the precompile code if the HF is greater than the one in which the precompile was introduced. A better one would be to have a list of precompiles for each HF, and merge them similar to the approach discussed in #543.
@jochem-brouwer jochem-brouwer self-assigned this Jun 17, 2020
@jochem-brouwer jochem-brouwer mentioned this issue Jun 17, 2020
Merged
@jochem-brouwer
Copy link
Member

Heya! Since I'm introducing the BLS precompiles I really think this should be added first. See the PR =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jochem-brouwer jochem-brouwer

Labels
effort: E1 hours package: vm prio: P2 very important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VM: return precompile functions based on hardfork ethereumjs/ethereumjs-monorepo
3 participants
@evertonfraga @s1na @jochem-brouwer