Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PoA chains #689

Closed
vpulim opened this issue Nov 15, 2018 · 3 comments
Closed

Support PoA chains #689

vpulim opened this issue Nov 15, 2018 · 3 comments

Comments

@vpulim
Copy link
Contributor

vpulim commented Nov 15, 2018

In Blockchain.prototype._putBlockOrHeader, it is assumed that the block is from a PoW chain:

    self.ethash.verifyPOW(block, function (valid) {
      next(valid ? null : new Error('invalid POW'))
    })

We need to properly handle PoA blocks. For now, we can simple skip the verifyPow call when block._common.consensus(hardfork) !== 'pow'

Also, depends on https://github.com/ethereumjs/ethereumjs-block/issues/45

@holgerd77
Copy link
Member

@jochem-brouwer following your linked issue from above, should we put this more prominently on the table (maybe not immediately but at least mid-term)? 🤔

Would be helpful if someone could collect some necessary base information and references to prepare for this (maybe directly by editing the initial comment for better visibility, pretty sure @vpulim will be ok with this).

@jochem-brouwer
Copy link
Member

@holgerd77
Copy link
Member

Solved by #1032 #1074 #1088 and #1103.

Will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants