Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util, devp2p: add dist.browser to package.json #1184

Merged
merged 8 commits into from
Apr 6, 2021

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Apr 2, 2021

This PR:

  • adds dist.browser to package.json for util and devp2p
  • adds missing types key to package.json for devp2p
  • updates some urls to new monorepo locations
  • moves some more important fields to the top, urls to bottom
  • normalizes some other fields across all packages

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #1184 (3cbae0a) into master (a141b52) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 82.25% <ø> (+0.03%) ⬆️
blockchain 84.23% <ø> (+0.06%) ⬆️
client 84.03% <ø> (+0.22%) ⬆️
common 86.87% <ø> (-0.53%) ⬇️
devp2p 84.06% <ø> (+0.14%) ⬆️
ethash 82.08% <ø> (ø)
tx 84.30% <ø> (+0.19%) ⬆️
vm 83.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, this is fitting well since I was planning to do a devp2p release during the week (unless anyone has any objections). 😄

"node": ">=8.0.0"
},
"files": [
"dist"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional to exclude bin here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that folder is not needed anymore since it now only contains the typescript source file. the actual built file we are interested in (that the package.json key for bin: ethereumjs points to) is now at dist/bin/cli.js

@holgerd77 holgerd77 merged commit 00fc597 into master Apr 6, 2021
@holgerd77 holgerd77 deleted the util-add-browser-dist branch April 6, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants