Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support npm run build command and fix run-transactions-simple example #152

Merged
merged 2 commits into from
Jul 28, 2017

Conversation

gasolin
Copy link
Contributor

@gasolin gasolin commented Jul 26, 2017

fix #149 and fix run-transactions-simple example

Copy link
Member

@wanderer wanderer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Docs are great! But I think we should remove the build from package.son

package.json Outdated
@@ -45,7 +45,8 @@
"testState": "node ./tests/tester -s",
"testBlockchain": "node --stack-size=1500 ./tests/tester -b",
"lint": "standard",
"test": "node ./tests/tester -a"
"test": "node ./tests/tester -a",
"build": "browserify index.js -o bundle.js"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this belongs in here, since the VM is not necessarily for standalone usage

@gasolin
Copy link
Contributor Author

gasolin commented Jul 28, 2017

The readme was described to generate the standalone bundle, I've updated the README to point it to the example.

@wanderer wanderer merged commit 4760718 into ethereumjs:master Jul 28, 2017
holgerd77 added a commit that referenced this pull request Dec 1, 2020
Upgrade to @ethereumjs/config-typescript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm run build command is not available
3 participants