New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client/vm: small fixes #1541
client/vm: small fixes #1541
Conversation
…ound listener after disconnect, tidy
…o can safely pass false
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -1,4 +1,4 @@ | |||
import multiaddr from 'multiaddr' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't the linter throw here? multiaddr
does not seem to be used in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is being used, as a default fall-back, on line 46
…tch into webpack/karma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 🙂
This PR aims to fix items 1, 2 and 4 from #1539