null address check before deleting account from trie #157

cdetrio · 2017-07-28T13:53:41Z

This fixes a bug introduced in 0b9e9a that was causing examples/run-transaction-complete to fail with:

address created: 692a70d2e424a56d2c6c27aa97d1a86395877b3a
----running tx-------
/ethereumjs-vm/examples/run-transactions-complete/index.js:74
    createdAddress = results.createdAddress
                            ^

TypeError: Cannot read property 'createdAddress' of undefined

wanderer · 2017-07-28T14:29:26Z

lib/cache.js

@@ -127,6 +127,9 @@ Cache.prototype.clear = function () {
 }

 Cache.prototype.del = function (key) {
+  if (key.toString('hex') === '') {
+    return
+  }


why is this nessicary?

done

Fix the typo of #157 also in JSDoc

Fix a typo in doc: lsetLength → setLengthLeft

…are release v1.0.2 (#157)

wanderer added the in progress label Jul 28, 2017

wanderer previously requested changes Jul 28, 2017

View reviewed changes

null address check before deleting account from trie

8a554b5

cdetrio force-pushed the fix-cache-del branch from 69c1cc1 to 8a554b5 Compare July 28, 2017 15:06

Update cache.js

09e1365

wanderer approved these changes Jul 28, 2017

View reviewed changes

wanderer merged commit 6a60906 into ethereumjs:master Jul 28, 2017

wanderer removed the in progress label Jul 28, 2017

evertonfraga added the package: vm label Feb 27, 2020

holgerd77 pushed a commit that referenced this pull request Mar 11, 2021

Fix a typo in doc: lsetLength → setLengthLeft

981531b

Fix the typo of #157 also in JSDoc

holgerd77 added a commit that referenced this pull request Mar 11, 2021

Merge pull request #157 from andy0130tw/patch-1

ff7bb86

Fix a typo in doc: lsetLength → setLengthLeft

holgerd77 pushed a commit that referenced this pull request May 26, 2023

Update deps to latest, add browser build, fix readme es5 import, prep…

2bc21b4

…are release v1.0.2 (#157)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

null address check before deleting account from trie #157

null address check before deleting account from trie #157

cdetrio commented Jul 28, 2017

wanderer Jul 28, 2017

null address check before deleting account from trie #157

null address check before deleting account from trie #157

Conversation

cdetrio commented Jul 28, 2017

wanderer Jul 28, 2017

Choose a reason for hiding this comment