Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: kiln v2 updates #1750

Merged
merged 18 commits into from Mar 8, 2022
Merged

merge: kiln v2 updates #1750

merged 18 commits into from Mar 8, 2022

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Feb 25, 2022

Continues #1703 with kiln v2 change set

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #1750 (6376509) into master (da0c698) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

Flag Coverage Δ
block 85.57% <ø> (ø)
blockchain 83.28% <ø> (ø)
client 75.27% <100.00%> (+0.13%) ⬆️
common 93.90% <ø> (ø)
devp2p 82.43% <ø> (+0.06%) ⬆️
ethash 90.76% <ø> (ø)
trie 86.18% <ø> (ø)
tx 89.94% <ø> (ø)
util 92.62% <ø> (ø)
vm 81.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

*/
get random() {
get prevRandao() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for a strange name? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g11tech
g11tech previously approved these changes Mar 8, 2022
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! left running for the night on devnet5, works like a charm 🚀

@ryanio
Copy link
Contributor Author

ryanio commented Mar 8, 2022

thanks @g11tech!! just shaped up the readme a bit and will merge after ci completes.

@ryanio ryanio merged commit e696120 into master Mar 8, 2022
@holgerd77 holgerd77 deleted the merge-kiln-v2 branch March 9, 2022 12:18
@ryanio ryanio restored the merge-kiln-v2 branch March 9, 2022 19:47
@ryanio ryanio deleted the merge-kiln-v2 branch March 11, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client: Kiln🔥🧱 Tracking Issue
3 participants