Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devp2p: remove async dependency from integration tests #1875

Merged
merged 2 commits into from
May 3, 2022

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented May 2, 2022

This PR removes the async dep from the devp2p integration tests.

I was getting some errors from the peer liveness check when the server closed too quickly so I added some 500ms delays before closing, not sure why I had this problem.

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1875 (120e314) into master (5851e72) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 85.57% <ø> (ø)
blockchain 83.82% <ø> (ø)
client 76.42% <ø> (ø)
common 94.19% <ø> (ø)
devp2p 82.47% <ø> (ø)
ethash 90.76% <ø> (ø)
trie 80.02% <ø> (ø)
tx 88.20% <ø> (ø)
util 92.62% <ø> (ø)
vm 81.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! 🙂

@holgerd77 holgerd77 merged commit 8e1c3cf into master May 3, 2022
@holgerd77 holgerd77 deleted the devp2p-remove-test-async-dep branch May 3, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants