Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @types/async-eventemitter from devDependencis to dependencies #2077

Merged
merged 2 commits into from Jul 26, 2022

Conversation

ScottyPoi
Copy link
Contributor

VM / EVM

From tracking issue #2032

evm:

@types/async-eventemitter is listed as devDependency: this should be a dependency, otherwise consumers cannot access the on property of EVM.

vm:

 @types/async-eventemitter is listed as devDependency: this should be a dependency, otherwise consumers cannot access the on property of VM.

@ScottyPoi ScottyPoi added PR state: needs review effort: E1 hours package: vm dependencies Pull requests that update a dependency file target: master (v7) Work to be done towards master branch package: evm labels Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #2077 (3dff1c6) into master (c1a319f) will increase coverage by 0.40%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 83.75% <ø> (ø)
blockchain 80.10% <ø> (ø)
client 78.30% <ø> (ø)
common 95.00% <ø> (ø)
devp2p 82.66% <ø> (+0.12%) ⬆️
ethash 90.81% <ø> (ø)
evm 40.89% <ø> (ø)
statemanager 84.55% <ø> (ø)
trie 82.52% <ø> (+1.69%) ⬆️
tx 92.18% <ø> (ø)
util 87.22% <ø> (ø)
vm 78.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jochem-brouwer jochem-brouwer merged commit b7436b2 into master Jul 26, 2022
@jochem-brouwer jochem-brouwer deleted the Move-packages-to-dependencies branch July 26, 2022 19:24
@acolytec3 acolytec3 mentioned this pull request Jul 26, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file effort: E1 hours package: evm package: vm PR state: needs review target: master (v7) Work to be done towards master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants