block: add new consensusFormatValidation flag #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabrocheleau
previously approved these changes
Aug 17, 2022
packages/block/src/header.ts
Outdated
| @@ -26,6 +26,7 @@ import { CLIQUE_EXTRA_SEAL, CLIQUE_EXTRA_VANITY } from './clique' | |||
| import type { BlockHeaderBuffer, BlockOptions, HeaderData, JsonHeader } from './types' | |||
| import type { CliqueConfig } from '@ethereumjs/common' | |||
|
|
|||
|
|
|||
packages/block/src/types.ts
Outdated
| @@ -1,3 +1,4 @@ | |||
|
|
|||
packages/block/src/types.ts
Outdated
| @@ -69,6 +69,10 @@ export interface BlockOptions { | |||
| * Will throw if provided on a non-PoA chain. | |||
| */ | |||
| cliqueSigner?: Buffer | |||
| /** | |||
| * Perform consensus validation checks on header if set. Defaults to true. | |||
There was a problem hiding this comment.
Suggested change
| * Perform consensus validation checks on header if set. Defaults to true. | |
| * Perform consensus validation checks on header if set. Defaults to true. |
packages/block/test/header.spec.ts
Outdated
| (err: any) => err.message.includes('transactionsTrie must be 32 bytes'), | ||
| 'throws on invalid transactionsTrie root hash length' | ||
| ) | ||
| let nonce = Buffer.alloc(5) |
There was a problem hiding this comment.
Not a big deal, but I find the nonce reassignment a bit weird. Could we just either scope it differently or directly assign fromHeaderData({nonce: Buffer.alloc(5)}) ?
gabrocheleau
approved these changes
Aug 17, 2022
|
Just a short additional LGTM from my side as well, @acolytec3 thanks for addressing! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2135