Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evm/vm: update event signatures #2184

Merged
merged 1 commit into from Aug 19, 2022
Merged

evm/vm: update event signatures #2184

merged 1 commit into from Aug 19, 2022

Conversation

jochem-brouwer
Copy link
Member

If you listen to an event in evm or vm asynchronously, then you need to call a continuation function once you are done;

vm.on('afterTx',  async (e, cont) => {
... do async stuff
cont()
})

However, our type signatures stated that this cont function should always be called with an argument, which is not the case.

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #2184 (d2ce4bf) into master (482caf9) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 93.07% <ø> (ø)
blockchain 88.82% <ø> (ø)
client 86.67% <ø> (ø)
common 98.09% <ø> (ø)
devp2p 92.30% <ø> (+0.05%) ⬆️
ethash ∅ <ø> (∅)
evm 62.97% <ø> (ø)
rlp ?
statemanager 88.71% <ø> (ø)
trie 89.27% <ø> (ø)
tx 97.98% <ø> (ø)
util 93.14% <ø> (ø)
vm 85.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit 7b1e38c into master Aug 19, 2022
@acolytec3 acolytec3 deleted the update-eventemitter-type branch August 19, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants