util: Add ssz roots capability for withdrawals hash tree root #2488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
acolytec3
requested changes
Jan 18, 2023
| @@ -103,6 +103,15 @@ export class Withdrawal { | |||
| return Withdrawal.toBufferArray(this) | |||
| } | |||
|
|
|||
| toValue() { | |||
There was a problem hiding this comment.
This is nice! I wonder if we should add something like this for blob txns?
There was a problem hiding this comment.
yes its good 👍 picked idea from ssz code structure
Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
|
|
||
| const withdrawalsValue = withdrawals.map((wt) => wt.toValue()) | ||
| st.deepEqual( | ||
| withdrawalsValue.map((wt) => `0x${wt.address.toString('hex')}`), |
There was a problem hiding this comment.
0x3355df6D4c9C3035724Fd0e3914dE96A5a83aaf4
| const withdrawalsValue = withdrawals.map((wt) => wt.toValue()) | ||
| st.deepEqual( | ||
| withdrawalsValue.map((wt) => `0x${wt.address.toString('hex')}`), | ||
| withdrawalsJson.map((wt) => wt.address) |
There was a problem hiding this comment.
0x990De5Cc9Cc644F0703f6A09e084470a949eC370
| st.deepEqual( | ||
| withdrawalsValue.map((wt) => `0x${wt.address.toString('hex')}`), | ||
| withdrawalsJson.map((wt) => wt.address) | ||
| ) | ||
| st.end() |
There was a problem hiding this comment.
0x990De5Cc9Cc644F0703f6A09e084470a949eC370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for moving the ssz root gen capability for withdrawals, this PR adds ssz types and root gen utility method which can be later easily deployed
will just need to switch all Block.genWithdrawlsTrieRoot to Block.genWithdrawalsSSZRoot method when the spec moves to ssz root