-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run coveralls on travis #270
Conversation
a74e019
to
2ecfa5c
Compare
State tests cover 93% of |
Fun facts:
All the other missing lines are just cases of covering internal exceptions (creating a trie node failed, etc.) |
It is also possible to run multiple tests and combine the coverage files (which we should do). |
|
Very cool PR, also remember to add the badge to the README. |
@holgerd77 should be ok to merge now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, really looking forward to this.
@axic do you have the new list of missing test cases? I heard you found some expmod tests for large inputs. |
Using the "new" (15 days old) tests repo is handled in #272. Currently it fails on a modexp test case with a large input (gas calculation fails because the bignum exceeds 53bits). We haven't yet fixed the code to see the new coverage figures. |
Fix the types of the BN and RLP re-exports
Fixes #269.