Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce stateManager.copy() and use that in VM.copy() #276

Merged
merged 1 commit into from Apr 18, 2018
Merged

Introduce stateManager.copy() and use that in VM.copy() #276

merged 1 commit into from Apr 18, 2018

Conversation

axic
Copy link
Member

@axic axic commented Feb 13, 2018

No description provided.

@axic axic requested a review from holgerd77 February 13, 2018 14:12
holgerd77
holgerd77 previously approved these changes Feb 13, 2018
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, did a search to make sure no other occurrences of trie.copy() have been missed.

@coveralls
Copy link

coveralls commented Feb 13, 2018 •
edited

Coverage Status

Coverage decreased (-0.04%) to 85.412% when pulling 8fe46e5 on statemanager-copy into 9bc99c3 on master.

@axic
Copy link
Member Author

axic commented Feb 13, 2018

Probably shouldn't merge it outside of #266.

@axic axic merged commit 53d632e into master Apr 18, 2018
@axic axic deleted the statemanager-copy branch April 18, 2018 10:54
@axic axic removed the in progress label Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 left review comments

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@axic @coveralls @holgerd77 @evertonfraga