VM/SM/Blockchain/Trie/EVM: Copy() -> shallowCopy() function renaming

[scorbajio]

TODO:

• VM (see VM: research copy behavior #2833)
• StateManager
• Blockchain
• Trie
• Evm
• Ethash

[holgerd77]

Quick note: after an exchange with @jochem-brouwer we realized that the EVM copy() method also has state and therefore should be renamed as well.

[codecov]

Codecov Report

Merging #2826 (97c94cd) into master (49cf084) will decrease coverage by 2.75%.
The diff coverage is 100.00%.

Additional details and impacted files

Flag	Coverage Δ
block	89.16% <ø> (ø)
blockchain	92.56% <100.00%> (ø)
client	?
common	97.06% <100.00%> (ø)
devp2p	86.95% <ø> (ø)
ethash	∅ <ø> (∅)
evm	66.99% <100.00%> (ø)
rlp	∅ <ø> (∅)
statemanager	86.41% <100.00%> (ø)
trie	90.08% <100.00%> (+0.04%)	⬆️
tx	?
util	86.54% <ø> (ø)
vm	77.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[holgerd77]

Did a branch update here via UI

[holgerd77]

Another branch update via UI

[holgerd77]

This looks pretty good, thanks a lot! 🤩

One thing: it would be good if we give this a mention in the direct code docs above the - now - shallowCopy() methods - what the "shallow" part of the copy actually is, so that this gets a bit of a description, something like the following for EVM:

/**
* This method copies the EVM, current HF and EIP settings
* and returns a new EVM instance.
* 
* Note: this is only a shallow copy and both EVM instances
* will point to the same underlying state DB.
* 
* @returns EVMInterface
*/

Will merge though, this can be done in a small follow-up PR (also ok: alongside another PR).

[scorbajio]

Working on documentation update in #2855.