Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: Fix genesis parsing for 4844 #2847

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Common: Fix genesis parsing for 4844 #2847

merged 3 commits into from
Jul 3, 2023

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Jul 2, 2023

To test latest hivecancun tests (@ https://github.com/ethereum/hive/commits/fb7ea843fb3935cd49197597a0454691b6a58820 ) :

git remote add spencer-tb git@github.com:spencer-tb/hive.git
git fetch spencer-tb
git checkout fb7ea843fb3935cd49197597a0454691b6a58820

Or branch: hive-cancun-devnet7

Run hive:

./hive --sim pyspec --sim.limit "pyspec/cancun" --client ethereumjs --docker.output

(limits to Cancun tests, remove sim.limit to run all pyspec tests since there are also shanghai -> cancun fork tests)

Example command to filter one test and get more output:

./hive --sim pyspec --sim.limit "pyspec/cancun/eip4844_blobs/blob_txs/blob_tx_attribute_calldata_opcodes/003-fork=Cancun-tx_gas=500000-single_byte-opcode=CALLDATALOAD" --client ethereumjs --docker.output

(Replaces #2846)

Thanks to @spencer-tb 😄

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #2847 (9901aac) into master (499c496) will increase coverage by 0.02%.
The diff coverage is 89.39%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 89.16% <95.00%> (-0.02%) ⬇️
blockchain 92.56% <92.10%> (+0.04%) ⬆️
client 87.08% <86.50%> (+<0.01%) ⬆️
common 97.06% <100.00%> (+<0.01%) ⬆️
devp2p 86.95% <85.29%> (+0.01%) ⬆️
ethash ∅ <ø> (∅)
evm 66.99% <83.78%> (-0.01%) ⬇️
rlp ∅ <ø> (∅)
statemanager 86.41% <96.22%> (-0.05%) ⬇️
trie 90.04% <87.50%> (+0.02%) ⬆️
tx 95.96% <100.00%> (-0.01%) ⬇️
util 86.54% <93.75%> (+0.46%) ⬆️
vm 77.25% <78.26%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77 holgerd77 marked this pull request as ready for review July 3, 2023 09:35
@holgerd77
Copy link
Member

Rebased this via UI

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 changed the title Fix genesis parsing for 4844 Common: Fix genesis parsing for 4844 Jul 3, 2023
@holgerd77 holgerd77 merged commit 49cf084 into master Jul 3, 2023
40 of 41 checks passed
@holgerd77 holgerd77 deleted the hive-cancun-dvnt7-2 branch July 3, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants