Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Minor Releases (Holesky, Dencun devnet-10, Client UX, Performance) #3113

Merged
merged 32 commits into from
Nov 2, 2023

Conversation

holgerd77
Copy link
Member

@holgerd77 holgerd77 commented Oct 23, 2023

Follow-up on #2945 (breaking release round)

Release PR for all libraries except Ethash and Wallet with a focus on Holesky compatibility, Dencun devnet-10 support, client post-Merge UX and performance improvements around the EVM and other packages.

Most releases are done as minor releases if they contain major non-breaking functionality additions.

Client release also included as well as RLP with a major CI bugfix.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #3113 (1d5afc3) into master (ab4ba34) will decrease coverage by 0.37%.
The diff coverage is n/a.

❗ Current head 1d5afc3 differs from pull request most recent head 289dceb. Consider uploading reports for the commit 289dceb to get more accurate results

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.80% <ø> (ø)
blockchain 92.27% <ø> (ø)
client ?
common 98.19% <ø> (ø)
devp2p 86.32% <ø> (ø)
ethash ∅ <ø> (∅)
evm 71.93% <ø> (ø)
statemanager 90.13% <ø> (ø)
trie 89.76% <ø> (ø)
tx 96.36% <ø> (ø)
util ?
vm 76.20% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good apart from the devnet10 refrences be replaced by devnet 11

- Performance: New reoccurringly used BigInt constants (`BIGINT_0`, `BIGINT_32`, `BIGINT_2EXP96`,...) in the `bytes` module for reusage along performance optimizations, PR [#3050](https://github.com/ethereumjs/ethereumjs-monorepo/pull/3050)
- Performance: `bytesToBigInt()` performance optimization for 1-byte bytes, PR [#3054](https://github.com/ethereumjs/ethereumjs-monorepo/pull/3054)
- Fix a bug in `fromUtf8()`, PR [#3112](https://github.com/ethereumjs/ethereumjs-monorepo/pull/3112)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing comments here on #2923 regarding the new int32ToBytes and similar helpers added for verkle work.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the missing comment in the util changelog about the new int32ToBytes and related helpers.

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@holgerd77 holgerd77 merged commit c6d8b39 into master Nov 2, 2023
44 checks passed
@holgerd77 holgerd77 deleted the new-releases branch November 2, 2023 08:31
@holgerd77
Copy link
Member Author

Just published the following releases on npm:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants