Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for slim format conversion helpers #3114

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

scorbajio
Copy link
Contributor

This change introduces tests for util package account slim-format conversion helpers.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #3114 (3e4870e) into master (eeb74e4) will decrease coverage by 6.93%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.78% <ø> (?)
blockchain 92.27% <ø> (ø)
client 87.51% <ø> (?)
common 98.19% <ø> (ø)
ethash ∅ <ø> (?)
evm 71.87% <ø> (?)
rlp ∅ <ø> (∅)
statemanager 90.30% <ø> (?)
trie 90.32% <ø> (?)
tx 96.36% <ø> (?)
util 87.70% <ø> (+0.73%) ⬆️
vm 76.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

Updated this via UI

@holgerd77
Copy link
Member

Something is really totally off with our Codecov settings!

grafik

How can codecov (project!!!) report -6.93% for THIS PR??? 🤔 🤔 🤔

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty simple and clean tests, nice! 👍

Will merge.

@holgerd77 holgerd77 merged commit 61af5c3 into master Oct 25, 2023
42 of 43 checks passed
@holgerd77 holgerd77 deleted the account-util-tests branch October 25, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants