client: ensure executed block does not get pruned if head=final FCU

[jochem-brouwer]

This PR fixes:

./hive --client ethereumjs --sim ethereum/engine --sim.limit="engine-cancun/Valid NewPayload->ForkchoiceUpdated on Syncing Client

In this test, first FCU is called (after receiving the VALID newPayload):

  {
    headBlockHash: A
    safeBlockHash: A
    finalizedBlockHash: A
  }

We reply VALID

Then, FCU is called again, but now with:

  {
    headBlockHash: A
    safeBlockHash: B
    finalizedBlockHash: C
  }

B,C are known and VALID. However, before this PR we replied Syncing, since the pruneCachedBlocks will actually deleted the just-executed block A from the executed blocks. So if we FCU again (without newPayload which executes the block if this is possible) then it sees that the block is not executed (we thus start executing it) but reply early here with SYNCING.

Note: PR still draft because might fix other hive tests here too.

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c0d5fc8) 87.93% compared to head (d698c72) 86.92%.

Additional details and impacted files

Flag	Coverage Δ
block	88.34% <ø> (ø)
blockchain	91.61% <ø> (ø)
client	84.69% <0.00%> (?)
common	98.25% <ø> (ø)
devp2p	82.12% <ø> (ø)
ethash	∅ <ø> (∅)
evm	74.33% <ø> (ø)
genesis	99.98% <ø> (ø)
rlp	∅ <ø> (∅)
statemanager	77.02% <ø> (ø)
trie	89.29% <ø> (ø)
tx	95.45% <ø> (ø)
util	89.13% <ø> (ø)
vm	80.20% <ø> (ø)
wallet	88.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[holgerd77]

@jochem-brouwer what is the status of this PR?

[jochem-brouwer]

Ah right I intended this to include more hive fixes. We can use this PR to fix the Cancun failing hive tests, which I assigned myself to #3275.

[holgerd77]

@jochem-brouwer ah, can we then please rather take this one in and open a new one instead of re-cycle?

This re-purposing of PRs is always a bit problematic.

I would then merge this in here.

[jochem-brouwer]

Sure, that is fine!

[holgerd77]

Updated this via UI

[holgerd77]

Updated this via UI

[holgerd77]

LGTM