Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More example rewrites #3228

Merged
merged 5 commits into from
Jan 11, 2024
Merged

More example rewrites #3228

merged 5 commits into from
Jan 11, 2024

Conversation

acolytec3
Copy link
Contributor

More example rewrites

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bcb197) 87.92% compared to head (3800fc8) 87.93%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 87.52% <ø> (ø)
blockchain 91.60% <ø> (ø)
client 84.66% <ø> (+0.03%) ⬆️
common 98.25% <ø> (ø)
devp2p 82.15% <ø> (ø)
ethash ∅ <ø> (∅)
evm 76.96% <ø> (ø)
genesis 99.98% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 86.29% <ø> (ø)
trie 89.80% <ø> (ø)
tx 95.73% <ø> (ø)
util 89.13% <ø> (ø)
vm 80.83% <ø> (ø)
wallet 91.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@acolytec3 acolytec3 changed the title Common example rewrites More example rewrites Jan 11, 2024
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice, yeah, I enjoy this so much! LGTM, will merge.

// Block 1: 0xa1a061528d74ba81f560e1ebc4f29d6b58171fc13b72b876cdffe6e43b01bdc5
// Block 2: 0x5583be91cf9fb14f5dbeb03ad56e8cef19d1728f267c35a25ba5a355a528f602
}
main()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, finally something which works (also already tried) 👍

@holgerd77 holgerd77 merged commit 417b466 into master Jan 11, 2024
46 checks passed
@holgerd77 holgerd77 deleted the more-example-rewrites branch January 11, 2024 22:01
@acolytec3 acolytec3 mentioned this pull request Jan 16, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants