Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLRequests cleanup #3393

Merged
merged 10 commits into from May 3, 2024
Merged

CLRequests cleanup #3393

merged 10 commits into from May 3, 2024

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented May 3, 2024 •
edited

Clean-up following integration of EIP 6110, 7002, and 7685 code

  • Moves all CLRequest related code to vm/src/requests.ts
  • Adds detailed explanation of parsing Deposit event logs
  • Cleans up field/function naming
  • Adds prague config to test-runner from Prague test fixtures runner instructions #3387
  • Add better forkTime check for EIP 2935
  • Make test runner use Typescript code instead of dist/cjs/...
  • Add optional depositContractAddress field to ChainConfig in common

g11tech
g11tech reviewed May 3, 2024
View reviewed changes
packages/vm/src/requests.ts Outdated
}
}

export const DEPOSIT_CONTRACT_ADDRESS = '0x00000000219ab540356cBB839Cbe05303d7705Fa'
Copy link
Contributor

@g11tech g11tech May 3, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move this into Chain struct or in the chains field and do getParams since each chain will have its own address

holgerd77
holgerd77 previously approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice cleanup and improvements! 🙂🙏

holgerd77
holgerd77 approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

g11tech
g11tech approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acolytec3 acolytec3 mentioned this pull request May 3, 2024
Closed
@acolytec3 acolytec3 merged commit a84eaae into master May 3, 2024
33 of 34 checks passed
@acolytec3 acolytec3 deleted the cleanup-requests branch May 3, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
package: common package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acolytec3 @holgerd77 @g11tech @jochem-brouwer