Add support for pending in getTransactionCount
#3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -784,7 +786,16 @@ export class Eth { | |||
| if (account === undefined) { | |||
| return '0x0' | |||
There was a problem hiding this comment.
Was about to say that this should include pending txpool msgs from this account, but this is impossible since accounts do need to exist because otherwise they cannot pay the min basefee of 7 wei.
| const rpc = getRpcClient(startRPC(manager.getMethods())) | ||
|
|
||
| const res = await rpc.request(method, ['0xccfd725760a68823ff1e062f4cc97e1360e8d997', 'pending']) |
There was a problem hiding this comment.
Not sure, maybe we want to keep this test in it but now instead of using pending we use some invalid tag like unsupported or something.
There was a problem hiding this comment.
Meh I guess this is tested in the getBlock anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the response handler for
eth_getTransactionCountto support thependingblock option. This includes pending transactions currently in the local transaction pool in the transaction count.This is needed to allow our client to work with the tx fuzzer