Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run with the latest tests (ethereumjs-testing v1.2.1) #348

Merged
merged 2 commits into from
Sep 20, 2018

Conversation

holgerd77
Copy link
Member

This PR runs the VM on the latests tests, I've done a new ethereumjs-testing v1.2.1 release, also added some CHANGELOG entry on the updates on the testing repository.

I will close #305, since this brings not enough value with minimal changes and three commits to rebase this and bring this in order.

We can nevertheless reference this here for going back to the notes already done on some test results.

@holgerd77 holgerd77 changed the title Run with the latest tests -(ethereumjs-testing v1.2.1) Run with the latest tests (ethereumjs-testing v1.2.1) Aug 30, 2018
@holgerd77 holgerd77 changed the title Run with the latest tests (ethereumjs-testing v1.2.1) [WIP] Run with the latest tests (ethereumjs-testing v1.2.1) Aug 30, 2018
@holgerd77
Copy link
Member Author

First results:

Byzantium:
Still this one test ecmul_0-3_5616_28000_96 failing, see the v1.2.0 testing PR linked above.

Constantinople:
Test from above + new CREATE2 tests

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.078% when pulling a69bf82 on update-tests-v121 into 5ab31f9 on master.

Copy link
Member Author

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have now added the one failing test case to the broken tests list, since no one seems to have the time to fix atm and we need the updated tests to be able to continue with the constantinople implementation.

Will merge.

@holgerd77 holgerd77 merged commit 7b61f61 into master Sep 20, 2018
@holgerd77 holgerd77 deleted the update-tests-v121 branch September 20, 2018 09:18
@holgerd77 holgerd77 changed the title [WIP] Run with the latest tests (ethereumjs-testing v1.2.1) Run with the latest tests (ethereumjs-testing v1.2.1) Sep 20, 2018
@@ -14,7 +14,8 @@ const skipBroken = [
'TransactionCollisionToEmptyButCode', // temporary till fixed (2017-09-21)
'TransactionCollisionToEmptyButNonce', // temporary till fixed (2017-09-21)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see how these temporary things go 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants