Add API tests for index, stateManager #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sina Mahmoodi <itz.s1na@gmail.com>
s1na
force-pushed
the
test/api-index
branch
from
ad98f38
to
c9f6ad1
Compare
holgerd77
approved these changes
Oct 2, 2018
| @@ -2,6 +2,7 @@ const Buffer = require('safe-buffer').Buffer | |||
| const utils = require('ethereumjs-util') | |||
|
|
|||
| module.exports = { | |||
| fake: true, | |||
| @@ -227,7 +227,7 @@ proto.revert = function (cb) { | |||
| // | |||
| proto.getStateRoot = function (cb) { | |||
| var self = this | |||
| self.cacheFlush(function (err) { | |||
| self.cache.flush(function (err) { | |||
| st.equal(vm.stateManager.trie.root, util.KECCAK256_RLP, 'it has default trie') | ||
| st.ok(vm.blockchain.fake, 'it has fake blockchain by default') | ||
| st.end() | ||
| }) |
There was a problem hiding this comment.
Ok. This is so cool, that this stuff get's explicit here. 👍
| t.test('should be able to activate precompiles', (st) => { | ||
| let vm = new VM({ activatePrecompiles: true }) | ||
| st.notEqual(vm.stateManager.trie.root, util.KECCAK256_RLP, 'it has different root') | ||
| st.end() |
| vm = new VM({ chain: 'mainchain', hardfork: 'homestead' }) | ||
| st.fail('should have failed for invalid chain') | ||
| } catch (e) { | ||
| st.ok(e.message.includes('not supported')) |
| const vm = setupVM() | ||
| await runBlockchainP(vm) | ||
| st.end() | ||
| }) |
| .then(() => st.fail('it hasn\'t returned any errors')) | ||
| .catch((e) => { | ||
| st.equal(e.message, 'test', 'it has correctly propagated runBlock\'s error') | ||
| st.end() |
| await runBlockchainP(vm) | ||
|
|
||
| st.end() | ||
| }) |
|
|
||
| st.equal(stateManager._common.hardfork(), 'byzantium', 'it has default hardfork') | ||
| st.end() | ||
| }) |
|
|
||
| st.equal(res.balance.toString('hex'), 'fff384') | ||
| st.end() | ||
| }) |
|
Hey @holgerd77, thanks, I'm glad the quality was sufficient :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the series for adding API test coverage. It:
index.jsstateManager.js