Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivated fixed tests from skipped broken tests list #383

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

holgerd77
Copy link
Member

Just tested the tests marked as broken in the skipped tests list in tester.js.

The following tests are passing now and can be reactivated:

  'CreateHashCollision', // impossible hash collision on generating address
  'RecursiveCreateContracts',
  'createJS_ExampleContract', // creates an account that already exsists
  'CreateCollisionToEmpty', // temporary till fixed (2017-09-21)
  'TransactionCollisionToEmptyButCode', // temporary till fixed (2017-09-21)
  'TransactionCollisionToEmptyButNonce', // temporary till fixed (2017-09-21)
  'RevertDepthCreateAddressCollision', // test case is wrong
  'randomStatetest642', // BROKEN, rustbn.js error

Last test still failing is one test from ecmul_0-3_5616_28000_96.

@holgerd77 holgerd77 mentioned this pull request Nov 6, 2018
@holgerd77
Copy link
Member Author

No production code touched, just tests reactivated, will merge.

@holgerd77 holgerd77 merged commit 7390207 into master Nov 6, 2018
@holgerd77 holgerd77 deleted the reactivate-now-passing-skipped-broken-tests branch November 6, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants