Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix casting genesis state addresses to buffer #400

Merged
merged 1 commit into from Dec 5, 2018
Merged

Fix casting genesis state addresses to buffer #400

merged 1 commit into from Dec 5, 2018

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Dec 5, 2018

StateManager used Buffer.from(address, 'hex') to cast genesis state addresses to buffer, which returns empty after addresses were padded with 0x in ethereumjs/ethereumjs-common#33, resulting in some of the runBlock API tests failing.

@s1na
Fix casting genesis state addresses to buffer
931fc54 
Signed-off-by: Sina Mahmoodi <itz.s1na@gmail.com>
holgerd77
holgerd77 approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good analysis, thanks! Looks good!

@holgerd77 holgerd77 merged commit cae775d into master Dec 5, 2018
@holgerd77 holgerd77 deleted the bug/generateGenesis/parseHex branch December 5, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@s1na @holgerd77 @evertonfraga