Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for opts.state overwrite #415

Merged
merged 2 commits into from Jan 10, 2019
Merged

Bugfix for opts.state overwrite #415

merged 2 commits into from Jan 10, 2019

Conversation

holgerd77
Copy link
Member

Fixes #411

@holgerd77 holgerd77 requested a review from s1na January 10, 2019 10:56
@coveralls
Copy link

coveralls commented Jan 10, 2019 •
edited

Coverage Status

Coverage decreased (-0.005%) to 90.403% when pulling 240dab6 on fix-trie-overwrite-issue-on-activeprecompiles into 1587bef on master.

@holgerd77
Copy link
Member Author

Should be followed by a bugfix release once merged ASAP, since this is breaking on common API parameter usage.

s1na
s1na suggested changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a small API test case that verifies the issue is resolved? Otherwise makes sense.

@holgerd77
Copy link
Member Author

Have done.

@holgerd77
Copy link
Member Author

(did also do a short manual check if test case really fails on previous version)

@s1na
Copy link
Contributor

s1na commented Jan 10, 2019

@holgerd77 Great, thanks!

@holgerd77 holgerd77 merged commit 1270116 into master Jan 10, 2019
@holgerd77 holgerd77 deleted the fix-trie-overwrite-issue-on-activeprecompiles branch January 10, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1na s1na s1na approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opts.state and opts.activatePrecompiles are not compatible
4 participants
@holgerd77 @coveralls @s1na @evertonfraga