Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API doc types for Bloom filter methods #439

Merged
merged 1 commit into from Feb 13, 2019

Conversation

chikeichan
Copy link
Contributor

Fixes #332

Using the types that are expected in utils.keccak256, which is what add and check uses to process to params

@s1na
Copy link
Contributor

s1na commented Feb 13, 2019

There is a discussion (ethereumjs/ethereumjs-util#172) on making the API stricter by allowing only key types as parameters. Keccak256 wasn't mentioned and I assume the plan is to have it accept various parameter types, in which case this fix is justified. If it's decided to go with a stricter keccak256, we'd have to re-visit the docs here and fix them, but I think that'll take some time. We can probably merge this for now. What do you think @holgerd77?

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jacky! @s1na yes, think so too, so looks good for now.

@holgerd77 holgerd77 merged commit 0232a2e into ethereumjs:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API doc types and implementation for Bloom filter methods are inconsistent
4 participants