Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced static vm logTable with dynamic inline version in EXP opcode #450

Merged
merged 2 commits into from Feb 25, 2019

Conversation

holgerd77
Copy link
Member

Addresses #449, 1. List Item

@coveralls
Copy link

coveralls commented Feb 23, 2019

Coverage Status

Coverage increased (+1.0%) to 92.295% when pulling a20b07f on replace-vm-logTable-with-dynamic-exp-inline into 0f7e010 on master.

@holgerd77
Copy link
Member Author

Ah, this would be another 1%+ coverage increase. I know on the one hand this is cosmetics, on the other hands obscure code parts like these distract from the more important coverage improvement necessities.

Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I was confused what the role of logTable is sometime ago. This PR makes it clear it's not absolutely necessary and can be very much simplified without much performance penalty!

I just had a few small comments and questions, basically to understand better what EXP is doing and whether it can be simplified further.

lib/vm/opFns.js Outdated Show resolved Hide resolved
lib/vm/opFns.js Outdated Show resolved Hide resolved
lib/vm/opFns.js Show resolved Hide resolved
@holgerd77
Copy link
Member Author

In this first round I was only looking for some functional replacement without fully understand the functionality. Will go through your comments and have a look what can be integrated, definitely worth to do a second round here.

@holgerd77 holgerd77 force-pushed the replace-vm-logTable-with-dynamic-exp-inline branch from 39b2546 to ce56b8a Compare February 25, 2019 11:00
@holgerd77 holgerd77 force-pushed the replace-vm-logTable-with-dynamic-exp-inline branch from 0ab8b26 to a20b07f Compare February 25, 2019 12:22
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great now!

@holgerd77 holgerd77 merged commit f2bcbc4 into master Feb 25, 2019
@holgerd77 holgerd77 deleted the replace-vm-logTable-with-dynamic-exp-inline branch February 25, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants