Setup gradual process for migrating to Typescript #495
Conversation
| } | ||
|
|
||
| /** | ||
| * bitwise or blooms together | ||
| * @method or | ||
| * @param {Bloom} bloom | ||
| */ | ||
| or (bloom) { | ||
| or (bloom: Bloom) { | ||
| if (bloom) { | ||
| for (let i = 0; i <= BYTE_SIZE; i++) { | ||
| this.bitvector[i] = this.bitvector[i] | bloom.bitvector[i] |
There was a problem hiding this comment.
Looks good (the whole file), super-much a fan of making the API here more strict and restrict to Buffer.
| @@ -66,7 +66,7 @@ module.exports = class Memory { | |||
| } | |||
| } | |||
|
|
|||
| const ceil = (value, ceiling) => { | |||
| const ceil = (value: number, ceiling: number): number => { | |||
| const r = value % ceiling | |||
| if (r === 0) { | |||
| return value | |||
| } | ||
|
|
||
| return false | ||
| } | ||
| } |
There was a problem hiding this comment.
OK (file), yes, makes totally sense to inline this private method.
| "async": "^2.1.2", | ||
| "async-eventemitter": "^0.2.2", | ||
| "core-js-pure": "^3.0.1", |
There was a problem hiding this comment.
Seems to be ok as a new dependency, see here.
|
|
||
| b1.or(b2) | ||
| st.true(b1.check('value 2'), 'should contain "value 2" after or') | ||
| st.true(b1.check(utils.toBuffer('value 2')), 'should contain "value 2" after or') | ||
| st.end() | ||
| }) | ||
|
|
There was a problem hiding this comment.
OK, test adoption to the stricter Bloom filter API.
| "strict": true | ||
| }, | ||
| "include": ["./lib/**/*"] | ||
| } |
There was a problem hiding this comment.
Rest of the changes until here ok.
|
Side note 1: not mission-critical for the moment, just for the state of stuff: prettier/formatting is not working yet, or is it? Side note 2: let me know what concretely you are working on throughout the day, eventually (possible not, hmm 馃槢) I will also do one or two file transitions if I find the time. |
Well, the command runs, but I haven't fixed the errors :-D They were mostly on the
Sure! Until Monday I'll be working very sporadically and can't really plan it, but from Monday we can divide and conquer together ;) |
It obviously won't be possible to migrate the whole library to typescript at once. This PR sets up a process for migrating gradually. In the meanwhile JS and TS code will have to co-exist. To account for that:
babeldependenciestsconfig.jsonwhich allows JS code. All code is transpiled viatsc(even JS)dist) rather than source. This is until all source code has been migrated and can be later on revertedFor the first round, I've migrated
Bloom,StackandMemory(easier picks 馃槃):Bloom's API has also been limited to only acceptBuffer. Since this was only used internally, it shouldn't be a breaking changeStackalso only acceptsBN(droppedBufferas it wasn't being used)rlpas a dev dependency (due to version mismatch inethereumjs-util, will make a PR for that)Please let me know if you think this gradual process is suitable or not.
(To be merged into #479)