Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate runCall to typescript #510

Merged
merged 2 commits into from May 17, 2019
Merged

Migrate runCall to typescript #510

merged 2 commits into from May 17, 2019

Conversation

s1na
Copy link
Contributor

@s1na s1na commented May 16, 2019

It's not immediately clear to me which of the options were meant to be optional and which mandatory. I made all optional currently, but we should strict this further (the same applies for runCode).

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 95.23% when pulling aa87896 on ts/runCall into aa859a2 on v4.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks, looks good!

@s1na s1na merged commit acd56bf into v4 May 17, 2019
@s1na s1na deleted the ts/runCall branch May 17, 2019 09:46
@s1na s1na mentioned this pull request May 17, 2019
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants