VM v5 changes #767

evertonfraga · 2020-06-06T04:32:58Z

While reviewing, don't be scared by the amount of changes. Most of them were already reviewed in previous PRs. I advise looking at the commits' tab individually instead of the changes tab.

Below, a breakdown of the commits, showing their associated PRs and review state (✅/👁).

#	PR		Commit message
`e78085e`	#682	✅	block,blockchain,vm: Block release v3.0.0
`ebe8dc7`	#748	✅	update to ethereumjs-util 7.0.2
`909bf63`	#748	✅	ethereumjs-util BN ts build compatibility: remove use of `IBN`
`83fcc18`	#748	✅	Use caret for ethereumjs-util
`de9c2b7`	#679	👁	feat: Scoped packages Converts all `ethereumjs-xxx` packages of this monorepo to `@ethereumjs/xxx`

holgerd77 · 2020-06-09T09:49:20Z

Could you be more explicit here what parts here have already been reviewed? Also: if these have already been reviewed, wouldn't it be easier to merge these up-front into master instead of wrangling in here? I am always afraid on PRs like these since it is just extremely hard to keep oversight. Wouldn't it be easier to separate?

evertonfraga · 2020-06-09T14:26:52Z

@holgerd77 of course! I have updated the PR description with the requested information. Now I'm separating it in two parts:

v5 already approved prs that just need a quick check
improvements in manageable-sized PRs.

codecov · 2020-06-09T21:40:31Z

Codecov Report

Merging #767 into master will decrease coverage by 1.37%.
The diff coverage is 91.35%.

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
- Coverage   92.06%   90.68%   -1.38%     
==========================================
  Files          46       43       -3     
  Lines        3025     3018       -7     
  Branches      471      472       +1     
==========================================
- Hits         2785     2737      -48     
- Misses        145      188      +43     
+ Partials       95       93       -2

Flag	Coverage Δ
#account	`94.11% <ø> (ø)`
#block	`82.68% <86.79%> (-5.68%)`	⬇️
#blockchain	`89.22% <85.71%> (+0.07%)`	⬆️
#common	`93.52% <ø> (-0.26%)`	⬇️
#tx	`94.02% <100.00%> (ø)`
#vm	`93.10% <100.00%> (ø)`

Impacted Files	Coverage Δ
packages/block/src/header-from-rpc.ts	`66.66% <ø> (-20.84%)`	⬇️
packages/vm/lib/evm/eei.ts	`94.53% <ø> (ø)`
packages/vm/lib/evm/interpreter.ts	`98.18% <ø> (ø)`
packages/vm/lib/evm/opcodes.ts	`100.00% <ø> (ø)`
packages/vm/lib/runBlockchain.ts	`88.00% <ø> (ø)`
packages/block/src/header.ts	`66.94% <71.42%> (-21.59%)`	⬇️
packages/blockchain/src/index.ts	`87.79% <81.25%> (+0.07%)`	⬆️
packages/block/src/block.ts	`71.15% <88.23%> (-14.15%)`	⬇️
packages/block/src/from-rpc.ts	`86.66% <100.00%> (+0.45%)`	⬆️
packages/blockchain/src/dbManager.ts	`95.31% <100.00%> (+0.07%)`	⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47e8ca1...9f62112. Read the comment docs.

…h method

* tooling: adding script to inspect TS interface diffs * tooling: refactoring script to improve usability

* block: version bump * block: adds changelog from v2.2.1 to v3.0.0 * blockchain: integrating ethereumjs block 3.0.0 * blockchain: converting canonicalDifficulty to buffer * blockchain: instantiating Block with empty/undefined data * blockchain: integrating Block 3.0.0 * block: lint:fix changes * All siloed tests passing. * vm: lint fix * leftovers of a rebase * lint fix * lint fix * vm,block: integrating Block with Lerna * block: remove circular dependency to ethereumjs-blockchain introduced in ethereumjs/ethereumjs-block#93 * block: removing unnecessary npx command * block: lint fix * blockchain: removing typo * vm: fix BlockHeader import * blockchain: fixing block initialization [Buffer[], Buffer[], Buffer[]] format * vm: updating methods to async * vm: misc changes * block: describing recovery bit normalization statement * block: removing source linking * docs: update for all packages

…e compiler option `esModuleInterop`

* Readme package renaming * account: renaming package * block: Migrating to scoped packages * npm package URL * block: updating dependencies to scoped packages * blockchain: migrating to scoped packages * common: migrating to scoped packages * tx: migrating to scoped packages * vm: migrating to scoped packages * account,block: updating badges * vm: updating patch to scoped packages * fix: updating new occurrences of package names * fix: updating new occurrences of package names * fix: rebase re-touching * ci: updating Block ci file downgrading nyc in block

holgerd77 · 2020-06-10T08:55:45Z

There are some failing tests here? Will wait with a review for now until further notice.

evertonfraga · 2020-06-10T11:44:55Z

@holgerd77 yes, I am getting a MaxBufferError from Block tests, which I'm investigating now.

lerna ERR! MaxBufferError: stdout maxBuffer exceeded
lerna ERR!     at PassThrough.<anonymous> (/home/runner/.npm/_npx/3188/lib/node_modules/lerna/node_modules/get-stream/index.js:41:19)
lerna ERR!     at PassThrough.emit (events.js:327:22)
lerna ERR!     at addChunk (_stream_readable.js:297:12)
lerna ERR!     at readableAddChunk (_stream_readable.js:269:11)
lerna ERR!     at PassThrough.Readable.push (_stream_readable.js:214:10)
lerna ERR!     at PassThrough.Transform.push (_stream_transform.js:152:32)
lerna ERR!     at PassThrough.afterTransform (_stream_transform.js:96:10)
lerna ERR!     at PassThrough._transform (_stream_passthrough.js:46:3)
lerna ERR!     at PassThrough.Transform._read (_stream_transform.js:191:10)

evertonfraga · 2020-06-10T12:29:06Z

@holgerd77 ready for review!

The second part of this PR will be Changelog, so don't expect them here.

Note: istead of the usual rebase I make, I had chosen to bring changes from master in a merge-commit. Given this PR size, I didn't want to risk doing surgery-like rebases.

holgerd77

Phew, Everton, this is really impressive! 😄

I had a look at the commit history, skimmed over all non-scoped-packages PR additions (all look good) and then did a more thorough review on the scope package changes.

Some things to address.

evertonfraga · 2020-06-10T17:16:22Z

@holgerd77 I think your comment was incomplete.

evertonfraga · 2020-06-10T20:08:58Z

I have performed the changes requested in #679.

holgerd77

Yes, live following, looks good now! 😛 😊

evertonfraga added the PR state: needs review label Jun 6, 2020

evertonfraga requested a review from ryanio June 6, 2020 04:32

evertonfraga self-assigned this Jun 6, 2020

evertonfraga mentioned this pull request Jun 8, 2020

feat: importing ethashjs as @ethereumjs/ethash #766

Merged

2 tasks

evertonfraga added the PR state: do-not-merge label Jun 9, 2020

evertonfraga force-pushed the vm/release-v5 branch 2 times, most recently from de9c2b7 to d901eec Compare June 9, 2020 21:37

evertonfraga requested a review from holgerd77 June 9, 2020 21:44

evertonfraga added PR state: merge ready and removed PR state: needs review labels Jun 9, 2020

holgerd77 and others added 11 commits June 9, 2020 22:47

Added forkHash() method to Common class

1627d64

Updated chain files with forkHash property

d93e913

Added tests for forkHash() and internal _calcForkHash() functions

a4b2fef

Fixed linting errors

ea2fb48

Used native String.prototype.padStart() method in Common._calcForkHas…

852416a

…h method

refactor: sets default value on fn signature, removing manual check.

137037e

tooling: adding script to inspect TS interface diffs (#764)

e000296

* tooling: adding script to inspect TS interface diffs * tooling: refactoring script to improve usability

update to ethereumjs-util 7.0.2

654ef8a

ethereumjs-util BN ts build compatibility: remove use of IBN, remov…

472385c

…e compiler option `esModuleInterop`

Use caret for ethereumjs-util

8899e34

evertonfraga force-pushed the vm/release-v5 branch from 7715ac5 to a570ae5 Compare June 10, 2020 03:09

evertonfraga force-pushed the vm/release-v5 branch from a570ae5 to c211326 Compare June 10, 2020 03:59

Merge branch 'master' into vm/release-v5

ff5f2ba

ci(block): solving MaxBufferError issue

9864f64

holgerd77 requested changes Jun 10, 2020

View reviewed changes

evertonfraga added 2 commits June 10, 2020 15:58

docs: updating npmjs URL

2c1571b

fix: removing patch file

9f62112

evertonfraga requested a review from holgerd77 June 10, 2020 20:09

holgerd77 approved these changes Jun 10, 2020

View reviewed changes

evertonfraga merged commit 0b11b9a into master Jun 10, 2020

evertonfraga deleted the vm/release-v5 branch June 10, 2020 20:31

evertonfraga added this to the VM v5 milestone Jun 12, 2020

holgerd77 added the package: monorepo label Sep 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VM v5 changes #767

VM v5 changes #767

evertonfraga commented Jun 6, 2020 •

edited

Loading

holgerd77 commented Jun 9, 2020

evertonfraga commented Jun 9, 2020

codecov bot commented Jun 9, 2020 •

edited

Loading

holgerd77 commented Jun 10, 2020

evertonfraga commented Jun 10, 2020

evertonfraga commented Jun 10, 2020 •

edited

Loading

holgerd77 left a comment

evertonfraga commented Jun 10, 2020

evertonfraga commented Jun 10, 2020

holgerd77 left a comment •

edited

Loading

VM v5 changes #767

VM v5 changes #767

Conversation

evertonfraga commented Jun 6, 2020 • edited Loading

holgerd77 commented Jun 9, 2020

evertonfraga commented Jun 9, 2020

codecov bot commented Jun 9, 2020 • edited Loading

Codecov Report

holgerd77 commented Jun 10, 2020

evertonfraga commented Jun 10, 2020

evertonfraga commented Jun 10, 2020 • edited Loading

holgerd77 left a comment

Choose a reason for hiding this comment

evertonfraga commented Jun 10, 2020

evertonfraga commented Jun 10, 2020

holgerd77 left a comment • edited Loading

Choose a reason for hiding this comment

evertonfraga commented Jun 6, 2020 •

edited

Loading

codecov bot commented Jun 9, 2020 •

edited

Loading

evertonfraga commented Jun 10, 2020 •

edited

Loading

holgerd77 left a comment •

edited

Loading