Index eips by number instead of string
#872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
ryanio
force-pushed
the
eips-from-string-to-number
branch
from
7c230a3
to
c14e6bf
Compare
ryanio
force-pushed
the
eips-from-string-to-number
branch
from
c14e6bf
to
df0c3aa
Compare
ryanio
changed the title
number[] instead of string[] for new eips optioneips by number instead of string
holgerd77
approved these changes
Sep 15, 2020
This was referenced Sep 15, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the new
eipsoption in Common and VM to use typenumberinstead ofstring.The primary reasons discussed were for dev ex brevity (less bulky), and better long term performance (iterating and comparing numbers should be faster than strings).