Transition VM tests to TypeScript

[holgerd77]

This PR transitions the VM test suite to TypeScript. State and blockchain tests are converted, API tests partially. First thought we could merge this partial API test transtion state cause the test:API command runs with both js and ts files but then realized that the test:API:browser command fails and it is probably easier to convert all the API tests as well and then adopt the Karma config and not introduce some hybrid setup.

I will (likely) stop on this for now. If you want to continue here feel free to do so, then please announce here before on what files you will be working and don't push directly on the branch but open a separate PR towards this branch.

[codecov]

Codecov Report

Merging #881 into master will increase coverage by 1.88%.
The diff coverage is 100.00%.

Flag	Coverage Δ
#account	92.85% <ø> (ø)
#block	77.03% <ø> (ø)
#blockchain	80.13% <ø> (ø)
#common	92.85% <ø> (ø)
#ethash	83.33% <ø> (ø)
#tx	93.98% <ø> (?)
#vm	87.64% <100.00%> (+5.45%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[holgerd77]

Note: this is now also getting under the reign of the linter, therefore there are more changes than the manual ones along the transition.

[jochem-brouwer]

Have glanced over it, will have to take a deeper look later. I also love that tests are now being linted! 😄

[ryanio]

woo thanks for starting this!

it looks like tests/api/EIPs/EIP2537-BLS-tests.js was erroring out with Cannot find module '../../util' since it was converted to ts, so i converted that file for now and can do some more conversion work in a separate PR as you suggested.

in working on that file I noticed that the vm.runCall opts are all taken in as Buffers so that would be some good future work to update them to better types (Address, BN, etc.)

i also updated the coverage:test script to accept ts

[evertonfraga]

That's great! :D

As a following step, maybe we can keep a bare minimum of JS tests, to ensure the behavior of the API in the JS world. I realized how important this was when we had the discussion of undefined vs. null when instantiating classes. In the TS world it wouldn't compile, and in JS it would create a class with a weird state, with high risk of bugs down the road.

[ryanio]

@evertonfraga that's a good idea, hm ok i was thinking of fully transitioning over to karma-typescript from karma-browserify but in that case if we want to keep some sanity JS tests we can probably use allowJs: true

[ryanio]

ok, this looks good to me now!

[holgerd77]

Woah, unbelievable PR, you really can't stop once you started, right? 😂

😁😄😆

Really great, will merge.

[jochem-brouwer]

Love this PR and the lighting speed it was written!! 😍