You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Along with an update of the version of the secp2561 dependency #228 we were close to updating a re-export with a breaking version within a minor ethereumjs-util release, see the comment from @alcuadrado for context.
To have this more structurally addressed and not only rely on reviewer awareness we should add some test cases running some API functionality of the re-exports (BN.js, RLP, secp2561). I would suggest to start slow here and add 3-5 test cases of central functionality of the libraries (we can't realistically test the whole API) for each re-export to the new test/externals.spec.ts test file.
This won't be the everything-covered solution but already significantly enlarge the chance to catch structural changes like a reworked error handling or a Node version dropped in the re-export library.
I would suggest (first thought, open for improvements along the way) to do at least the following tests for each library:
Use a function as intended
Trigger a well-defined error case on a function
Eventually trigger a not-so-well defined error case (wrong input)
The error case differentiation is a bit blurry, might be best to decide on a case-by-case basis what is practical.
The text was updated successfully, but these errors were encountered:
Along with an update of the version of the
secp2561
dependency #228 we were close to updating a re-export with a breaking version within a minorethereumjs-util
release, see the comment from @alcuadrado for context.To have this more structurally addressed and not only rely on reviewer awareness we should add some test cases running some API functionality of the re-exports (BN.js, RLP, secp2561). I would suggest to start slow here and add 3-5 test cases of central functionality of the libraries (we can't realistically test the whole API) for each re-export to the new
test/externals.spec.ts
test file.This won't be the everything-covered solution but already significantly enlarge the chance to catch structural changes like a reworked error handling or a Node version dropped in the re-export library.
I would suggest (first thought, open for improvements along the way) to do at least the following tests for each library:
The error case differentiation is a bit blurry, might be best to decide on a case-by-case basis what is practical.
The text was updated successfully, but these errors were encountered: