Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Change browser from Chrome to ChromeHeadless #156

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

ossdev07
Copy link
Contributor

Changing the browser from Chrome to ChromeHeadless

As when using chromium binary to launch chrome then getting issues

16 10 2018 07:27:28.210:ERROR [launcher]: Cannot start Chrome

16 10 2018 07:27:28.211:ERROR [launcher]: Chrome stdout:
16 10 2018 07:27:28.211:ERROR [launcher]: Chrome stderr:
16 10 2018 07:27:28.211:INFO [launcher]: Trying to start Chrome again (1/2).

16 10 2018 07:27:28.756:ERROR [launcher]: Cannot start Chrome

16 10 2018 07:27:28.757:ERROR [launcher]: Chrome stdout:
16 10 2018 07:27:28.757:ERROR [launcher]: Chrome stderr:
16 10 2018 07:27:28.768:INFO [launcher]: Trying to start Chrome again (2/2).
16 10 2018 07:27:29.292:ERROR [launcher]: Cannot start Chrome

16 10 2018 07:27:29.293:ERROR [launcher]: Chrome stdout:
16 10 2018 07:27:29.293:ERROR [launcher]: Chrome stderr:
16 10 2018 07:27:29.300:ERROR [launcher]: Chrome failed 2 times (cannot start). Giving up.

But, if using chromeHeadless in place of Chrome then the browser launches

Headless browsers provide automated control of a web page in an environment similar to popular web browsers, but are executed via a command-line interface or using network communication

Signed-off-by: ossdev ossdev@puresoftware.com

change chrome to chromeheadless

Signed-off-by: ossdev <ossdev@puresoftware.com>
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just checked, since Headless Chrome is now shipped within Chrome for 10 versions (since 59, now 69) I think we can do this change. Thanks for the PR!

@holgerd77 holgerd77 merged commit eb96e84 into ethereumjs:master Oct 16, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.219% when pulling 21624a6 on ossdev07:chrome_headless into 5347bdb on ethereumjs:master.

@ossdev07
Copy link
Contributor Author

Thanks, @holgerd77 for approving this PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants