This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Fix isValidSignature method #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes.
This first is minor: the docs for
isValidSignaturesay thatvshould be aBuffer, but the code assumes it is anumber. This PR updates the doc, as changing the code would be a breaking change.The second is a more significant bug. Prior to this PR,
isValidSignaturewill return false if passed an s-value greater than secp256k1n/2 AND ifhomestead === false. However, the EIP that introduced this https://github.com/ethereum/EIPs/blob/master/EIPS/eip-2.md was the primary homestead EIP. The code seems much more correct if we instead check that homestead is true. This is consistent with what is currently done inethereumjs-tx(for example). This PR updates that line of code accordingly.