This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Make bytes methods type strict #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
force-pushed
the
split-bytes-methods
branch
from
0734ef7
to
d1fc502
Compare
cgewecke
commented
Apr 27, 2020
holgerd77
suggested changes
Apr 27, 2020
src/bytes.ts
Outdated
| */ | ||
| export const setLengthLeft = function(msg: any, length: number, right: boolean = false) { | ||
| export const setLengthLeft = function(msg: Buffer, length: number, right: boolean = false) { |
There was a problem hiding this comment.
Hmm, this is pretty confusing to have this boolean right parameter in the API. Can we instead do an internal setLength method and move the logic over there and do function signature (so: function(msg: Buffer, length: number)) and internal structure analogue to setLengthRight?
There was a problem hiding this comment.
Yes, that's definitely nicer.
There was a problem hiding this comment.
Addressed in a2a50ae
src/bytes.ts
Outdated
| * @param a (Buffer) | ||
| * @return (Buffer) | ||
| */ | ||
| export const unpadBuffer = function(a: any): Buffer { |
There was a problem hiding this comment.
I assume having an any type here is a mistake?
There was a problem hiding this comment.
Addressed in 1f2803c
src/bytes.ts
Outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #172 Breaking API changes
(Will make similar changes for the methods in hash.ts and signature.ts in a separate PR)