Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

New release v7.0.0 #249

Merged
merged 7 commits into from
Apr 30, 2020
Merged

New release v7.0.0 #249

merged 7 commits into from
Apr 30, 2020

Conversation

holgerd77
Copy link
Member

No description provided.

@github-actions
Copy link

Coverage Status

Coverage remained the same at 99.705% when pulling 51b258b on new-release-v700 into f86dc07 on master.

@holgerd77
Copy link
Member Author

holgerd77 commented Apr 29, 2020

Hmm, just wondered what's with BN.js v5.x? Should we update there as well? Will likely be more future-proof and there are at least some performance benefits it seems (read out of the release notes).

Update: Here is also some release context indutny/bn.js#219

Update: Ah, but there are no up-to-date type definitions (still on 4.11.3)

Update: Seems to be no significant API changes though so maybe ok to stick with the @types/bn.js v4.11.3 package

@holgerd77 holgerd77 requested a review from s1na April 29, 2020 22:46
@holgerd77
Copy link
Member Author

Self-note: we should also add Node 14 to the test matrix, just tested locally with 14.1.0 and tests are passing.

@holgerd77
Copy link
Member Author

holgerd77 commented Apr 30, 2020

Ok, I've now done the changes I discussed/mentioned above:

  • Added Node 14
  • Updated BN.js re-export to v5
  • Added the engines field (discussed here)

Open for review again, please take this into account.

cgewecke
cgewecke previously approved these changes Apr 30, 2020
Copy link
Contributor

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog looks great to me. Very clear. 💯

Only thought I have is that it might be helpful to mention the existence of the toBuffer method in the release notes or something, for people who've been relying on it being automatically invoked.

@holgerd77
Copy link
Member Author

Ok, makes sense and have added (note on toBuffer). This needs reapproval now.

@cgewecke cgewecke self-requested a review April 30, 2020 20:37
@holgerd77 holgerd77 merged commit 03bb3ff into master Apr 30, 2020
@holgerd77 holgerd77 deleted the new-release-v700 branch April 30, 2020 20:41
@holgerd77
Copy link
Member Author

holgerd77 commented Apr 30, 2020

Just published as v7.0.0 on npm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants