This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Handle signatures for chainIds greater than 110 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature module was assuming that the `v` recovery value fit in a single byte. With chainIds larger than 110, since `v(110) = 110 * 2 + 35 = 255`, this assumption breaks (see chainid.network for a list of chainIds with large values). This commit changes `fromRpcSig` so the recovery `v` value is not just the 65th byte of the signaure, but all bytes after the 64th.
|
Hi Santiago, great find, thanks for the submission! 😄 Also perfect PR with sufficient test coverage together with perfect timing (all too good to be true, hehe 😋 ) since I was just planning to do a bugfix release on the library today. So I will directly merge and prepare a release PR including this PR here. //cc @ryanio |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature module was assuming that the
vrecovery value fit in a single byte. With chainIds larger than 110, sincev(110) = 110 * 2 + 35 = 255, this assumption breaks (see chainid.network for a list of chainIds with large values).This commit changes
fromRpcSigso the recoveryvvalue is not just the 65th byte of the signaure, but all bytes after the 64th.