Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Support BN.isBN in toBuffer() #29

Merged
merged 2 commits into from
Jan 5, 2018
Merged

Support BN.isBN in toBuffer() #29

merged 2 commits into from
Jan 5, 2018

Conversation

axic
Copy link
Member

@axic axic commented Mar 8, 2016 •
edited by kumavis
Loading

WIP - needs tests first.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 99.559% when pulling 022acdc on axic:patch/isbn into 66effd6 on ethereumjs:master.

@axic
Copy link
Member Author

axic commented Nov 9, 2016

I'm not sure what to do with this. Essentially we should remove the toArray case because isBN supersedes it.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 99.206% when pulling 5fecf35 on axic:patch/isbn into c86d92b on ethereumjs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 99.142% when pulling 0316a8e on axic:patch/isbn into 338ee90 on ethereumjs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 99.142% when pulling c894f62 on axic:patch/isbn into 05f0cef on ethereumjs:master.

holgerd77
holgerd77 previously approved these changes Oct 13, 2017
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested this locally and made sure, that the new code path is actually triggered. Also good, that there is a new test case for this.

@axic
Copy link
Member Author

axic commented Jan 5, 2018

@holgerd77 I think this should be merged after the release

@holgerd77
Copy link
Member

@axic Ok

fanatid
fanatid previously approved these changes Jan 5, 2018
View reviewed changes
@holgerd77
Copy link
Member

@axic Can you rebase? This is coming from you repo!

@axic axic dismissed stale reviews from fanatid and holgerd77 via 1ec8717 January 5, 2018 11:54
@axic
Copy link
Member Author

axic commented Jan 5, 2018

Rebased.

@coveralls
Copy link

coveralls commented Jan 5, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-64.4%) to 34.783% when pulling 1ec8717 on axic:patch/isbn into 3e72947 on ethereumjs:master.

holgerd77
holgerd77 approved these changes Jan 5, 2018
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@holgerd77 holgerd77 merged commit 757ba73 into ethereumjs:master Jan 5, 2018
@axic axic deleted the patch/isbn branch January 5, 2018 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

@fanatid fanatid fanatid left review comments

@jwasinger jwasinger Awaiting requested review from jwasinger

Assignees

@axic axic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@axic @coveralls @holgerd77 @fanatid @wanderer