Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Implement importPublic() #34

Merged
merged 1 commit into from Apr 26, 2016
Merged

Conversation

axic
Copy link
Member

@axic axic commented Apr 18, 2016

Method to convert any public key to an Ethereum public key.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.174% when pulling 348b466 on axic:feature/convert-public into e92c836 on ethereumjs:master.

@wanderer
Copy link
Member

@axic it looks like we might have enough functions for keys that we could split all the key stuff out into its own file or even module. What do you think?

@axic
Copy link
Member Author

axic commented Apr 18, 2016

@wanderer I was thinking the same today to splitting into ethereumjs-crypto. It is hard to split it correctly though:
a) everything which requires secp256k1?
b) everything which is address/key related?

Most of the ethereumjs packages will need the crypto part too, though other users could avoid using that if they only need buffer utils (that's left in utils after crypto).

@wanderer
Copy link
Member

which out of a or b is the largest subset? I think its b. Then we could split ethereumjs-util into two files key-stuff.js and buffer-stuff.js. index.js would still export all the function in both the files but users could decided to only include one of the subfiles. Which would be good for shaving off bits for browsers

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling dd75fdf on axic:feature/convert-public into b49714a on ethereumjs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2020e9c on axic:feature/convert-public into d4cd539 on ethereumjs:master.

@axic axic changed the title Implement convertPublic() Implement importPublic() Apr 26, 2016
@axic axic force-pushed the feature/convert-public branch 2 times, most recently from 430c26d to a4610b1 Compare April 26, 2016 12:02
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a4610b1 on axic:feature/convert-public into d4cd539 on ethereumjs:master.

@axic axic merged commit 7ae2feb into ethereumjs:master Apr 26, 2016
@axic axic deleted the feature/convert-public branch April 26, 2016 12:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants