This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Introduce toMessageSig() and fromMessageSig() #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this function being used somewhere else? |
|
helpeth, testrpc (for eth_sign), I think @kumavis uses it for something? It is getting some usage since it became easier to validate within a contract a few weeks back (see https://gist.github.com/axic/5b33912c6f61ae6fd96d6c4a47afde6d). |
|
usecase look good to me. Maybe change the name to |
axic
force-pushed
the
feature/web3-sign-serialise
branch
from
446e3be
to
7c58b57
Compare
|
@axic can you add a test? plz |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge yet.
Checking if this makes sense, cc @wanderer @kumavis
Fixes #36